core#1182 - revert crm.menubar.js changes

[MegaphoneJon]

Overview

CiviCRM 5.16.0 has a race condition that causes the menubar to not function.

Before

Menubar rarely works.

After

Menubar works.

Technical Details

This commit is the issue. I note that there's only one HTML element with an id of crm-container but several with the class of crm-container. I imagine that under certain circumstances one of those elements loads before the menubar, causing crm.menubar.js to not work.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

I still don't think relying on the crm-container id is a good idea in the long-run, but if using the class breaks stuff then I agre with reverting it.