dev/core#1188 Fix API v3 error Class or interface CiviCRM_API3_Exception does not exist

[prondubuisi]

Overview

Static analysis tool Psalm reveals the above error, this is an attempt to fix it as a proof of concept that Psalm errors within civi-core can actually be fixed

Before

Psalm autoloader cannot find CiviCRM_API3_Exception

After

Autoloader can find CiviCRM_API3_Exception

Technical Details

This is not a problem with runtime php because the API_Exception is invariably thrown before the CiviCRM_API3_Exception and since they are both in the same file the require_once for API_Exception also covers CiviCRM_API3_Exception. However, for static code analysers (like Psalm) the processing order is not driven by the order of runtime events

Comments

[civicrm-builder]

Can one of the admins verify this patch?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

add to whitelist

[eileenmcnaughton]

@seamuslee001 I'm ready to merge this - do you have any hesitation?

[eileenmcnaughton]

I'm merging this as it is constrained to one class which is 'special' and is safe IMHO