Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Import] [Test] Initial test on loadSavedMapping function. #15050

Merged
merged 1 commit into from
Aug 18, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Adds a test - minor changes to support it

Before

No test

After

Minimal testing - more to come

Technical Details

To facilitate this I
1) made it public - in the end it will go anyway
2) removed a 'pass-through' variable from the return array - it is passed in & returned unchanged
3) made it cope without a notice when a class property is not defined - that will go too soon

Comments

Will rebase if #15049 is merged first

@civibot
Copy link

civibot bot commented Aug 15, 2019

(Standard links)

@civibot civibot bot added the master label Aug 15, 2019
@eileenmcnaughton eileenmcnaughton force-pushed the loadmappingtest branch 3 times, most recently from 8ae08d6 to 1ab5cdf Compare August 16, 2019 00:46
@eileenmcnaughton eileenmcnaughton changed the title Initial test on loadSavedMapping function. [Import] [Test] Initial test on loadSavedMapping function. Aug 16, 2019
To facilitate this I
1) made it public - in the end it will go anyway
2) removed a 'pass-through' variable from the return array - it is passed in & returned unchanged
3) made it cope without a notice when a class property is not defined - that will go too soon
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 I rebased this now you merged the other

@seamuslee001
Copy link
Contributor

Looks fine adding Merge on Pass

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@seamuslee001 seamuslee001 merged commit 250a9c3 into civicrm:master Aug 18, 2019
@seamuslee001 seamuslee001 deleted the loadmappingtest branch August 18, 2019 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants