Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Group search message fix #15052

Merged
merged 1 commit into from
Aug 19, 2019
Merged

Conversation

19ATF72
Copy link
Contributor

@19ATF72 19ATF72 commented Aug 16, 2019

Overview

When searching for group it looks like the search was performed by the site name.
New message is more user friendly

Before

K2YbOSY

After

2y4BGTr

Steps to reproduce

1.Click "View contact record"
2.Click "Contact" → "Manage Group"
3.Try to find some non-existent group
4.Take a look at the message: "No Groups have been created for this site."

@civibot
Copy link

civibot bot commented Aug 16, 2019

(Standard links)

@civibot civibot bot added the master label Aug 16, 2019
@yashodha
Copy link
Contributor

@19ATF77 I think we can change the verbiage to No groups match the search criteria since filter could be anything - name, creator name, etc

Also Nan looks off. The whole line and pager should go away for zero results.
group

@colemanw
Copy link
Member

For some time now we have been standardizing our empty search results string to "None found." This makes it easy on translators to reuse the same string everywhere rather than have to translate dozens of slight variations ("No groups found" "No activities found" "No contacts found" etc.)

@19ATF72
Copy link
Contributor Author

19ATF72 commented Aug 19, 2019

@colemanw that makes a lot of sense, changed it now.
Thanks for your time @yashodha , @colemanw .

@yashodha
Copy link
Contributor

@19ATF77 thanks! Can you please squash all your commits?

@19ATF72
Copy link
Contributor Author

19ATF72 commented Aug 19, 2019

Done,
Thanks

@alifrumin
Copy link
Contributor

@Coleman, I tested this on the jenkins build and it looks merge ready to me
noneFound

@seamuslee001
Copy link
Contributor

Thanks @19ATF77 and @alifrumin

@seamuslee001 seamuslee001 merged commit 10641c2 into civicrm:master Aug 19, 2019
@19ATF72 19ATF72 deleted the manageGroupFixes branch August 20, 2019 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants