Remove deprecated unused function.

[eileenmcnaughton]

Overview

I noticed this has been deprecated for over a year (& is unused). Removing

Before

After

Gone

Technical Details

We generally deprecate functions before removing them to ease the path of extensions calling BAO functions (which is not supported but this seems to reduce risk of pain). This removes

Comments

@mattwire

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

Confirmed that nothing else in universe references getMembershipTypesByOrg.

There is a subtle reference in tests/phpunit/CRM/Member/BAO/MembershipTypeTest.php (wherein a test-function is named for the removed function), but it appears the test's substance is now focused on the API equivalent. Small cleanup opportunity to move it somewhere else, but that's a minor nitpick.

Would do merge-on-pass.. Leaving 'merge-ready' b/c Eileen has a ping out to Matt about this one.

[eileenmcnaughton]

Merging as ping means ' you may be interested' not 'I need your response' - should I avoid pinging people in case it's seen as blocking?

[totten]

lol, no, please ping people who might be interested. 😄