Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for taking dynamic form name in grant search #15075

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

monishdeb
Copy link
Member

Overview

If we need to override existing grant search form on different url callback than core CiviCRM. Search will work fine , but as form name is hardcoded in core it's not taking the new form name and because of that task actions are not working properly . If we select some contacts and go to any action it will select all contacts.

Before

Currently, we if create new url and override core grant search form, select actions not working.

After

Overridden search form will work well with all select actions.

Comments

Reopened against #14172

@civibot
Copy link

civibot bot commented Aug 19, 2019

(Standard links)

@monishdeb
Copy link
Member Author

monishdeb commented Aug 19, 2019

I have tested this patch and works fine for me.

@sushantpaste @yashodha @eileenmcnaughton I think this PR can be merged after test-build pass.

@yashodha
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

Ok I feel like this was just pending tests passing before - merging

@eileenmcnaughton eileenmcnaughton merged commit a284d62 into civicrm:master Aug 19, 2019
@monishdeb monishdeb deleted the core-14172 branch August 20, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants