dev/core#1192 - E_NOTICE on using Add Activity action on contact search results

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/issues/1192

E_NOTICE when using Add Activity from the actions dropdown for contact search results.

Before

Notice: Undefined index: allowRepeatConfigToSubmit in CRM_Core_Form_RecurringEntity::postProcess() (line 346 of /.../web/sites/all/modules/civicrm/CRM/Core/Form/RecurringEntity.php

After

No notice.

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[alifrumin]

• General standards
  • Explain (r-explain)
    • PASS : Explained clearly in the pr and gitlab issue
  • User impact (r-user)
    • PASS: The change would be intuitive or unnoticeable for a majority of users who work with this feature.
  • Documentation (r-doc)
    • PASS: The changes do not require documentation.
  • Run it (r-run)
    • PASS: I logged into the test site on jenkins ->ran a contacts search -> selected "Add Activity" from the actions dropdown and did not receive an e-notice
• Developer standards
  • Technical impact (r-tech)
    • PASS: Seems fine to me
  • Code quality (r-code)
    • PASS: The functionality, purpose, and style of the code seems clear+sensible.
  • Maintainability (r-maint)
    • PASS: the change is trivial enough that it does not require tests.
  • Test results (r-test)
    • PASS: The test results are all-clear.

@eileenmcnaughton this change looks mergable to me. Thank you @demeritcowboy

[demeritcowboy]

Thanks @alifrumin

[eileenmcnaughton]

yes thanks @alifrumin & @demeritcowboy !