Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] [NFC] upgrade remaining export tests #15095

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Aug 21, 2019

Overview

Minor cleanup on Export test & remove a few lines from core fn which supported hackier test method

Before

Older helper used, more hacky

After

Newer helper used, hack removed

Technical Details

Fully switch to checking csv output with new helper - this allows us to remove the hack from the core fn

Comments

@civibot civibot bot added the master label Aug 21, 2019
@civibot
Copy link

civibot bot commented Aug 21, 2019

(Standard links)

Fully switch to checking csv output with new helper - this allows us to remove the hack from the core fn
@eileenmcnaughton eileenmcnaughton changed the title [Test] [NFC] upgrade remamining export tests [Test] [NFC] upgrade remaining export tests Aug 21, 2019
@seamuslee001
Copy link
Contributor

This is fine and talked it through with Eileen, plenty of tests already in this area merging

@seamuslee001 seamuslee001 merged commit 67f2954 into civicrm:master Aug 22, 2019
@eileenmcnaughton eileenmcnaughton deleted the export_metadata branch August 22, 2019 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants