[Import] [ref] - minor cleanup to reduce code complexity #15097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
import_cleanup
branch
from
fa743ec to
12e1448
Compare
|
@eileenmcnaughton test fail relates |
What we are doing here is actually very simple - despite the code being kinda insane - we are just getting the fields from the database for each column in the mapping. The fields are all loaded into the processor already & those functions are tested. This switches to using them and to passing around less variables... Follow ons will do the same for other fields (website_type_id, location_type_id but I will add more tests as I do that
eileenmcnaughton
force-pushed
the
import_cleanup
branch
from
12e1448 to
cd41fa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Use Processor to determine the phone_type_id & im_provider_id + add a test
Before
Code more crazy, less tested
After
Less crazy, more tested
Technical Details
What we are doing here is actually very simple - despite the code being kinda insane - we are just getting the fields from the database for each column in the mapping.
The fields are all loaded into the processor already & those functions are tested. This switches to using them and to passing around less variables...
Follow ons will do the same for other fields (website_type_id, location_type_id but I will add more tests as I do that
Comments