Ensure Dashboard respects multiple Domains #15099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@seamuslee001 I'm +1 on this - just pinging you to have a chance to input |
eileenmcnaughton
added
the
merge ready
| @@ -109,6 +109,7 @@ public static function getContactDashlets($contactID = NULL) { | |||
| 'contact_id' => $contactID, | |||
| 'is_active' => 1, | |||
| 'dashboard_id.is_active' => 1, | |||
| 'dashboard_id.domain_id' => CRM_Core_Config::domainID(), | |||
There was a problem hiding this comment.
@christianwach do we need to cope with dashboards that don't have a domain_id?
There was a problem hiding this comment.
@seamuslee001 There should always be a domain_id assigned to each dashlet when they are created. Personally I'd consider dashlets without a domain_id to be orphaned.
|
I'm ok with this and makes sense to me merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Please see the issue on Lab for details.
Before
domain_idof an existing Dashlet instead of creating a new Dashlet for that Domain.After