Fix an HTML error in Calculate.tpl

[mlutfy]

Overview

There was an HTML error with a 'span' tag that was not closed correctly because the markup was outside the condition.

I also did a bit of code-style cleanup.

Most of it is NFC, except that I added the string "for this participant" now moved inside the span. It doesn't make sense to have it outside.

Before

<div id="pricesetTotal" class="crm-section section-pricesetTotal">
--
   <div class="label
   " id="pricelabel">
   Total Fee(s)</span>
   for this participant      </div>
   <div class="content calc-value"  id="pricevalue" ></div>
   </div>

After

<div id="pricesetTotal" class="crm-section section-pricesetTotal">
--
   <div id="pricelabel" class="label ">
   <span id='amount_sum_label'>Total Fee(s) for this participant</span>
   </div>
   <div class="content calc-value"  id="pricevalue"></div>
  </div>

And on a membership page

<div id="pricesetTotal" class="crm-section section-pricesetTotal">
--
<div id="pricelabel" class="label ">
   <span id='amount_sum_label'>Total Amount</span>
   </div>
   <div class="content calc-value"  id="pricevalue"></div>
   </div>

No noticeable visible change

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[eileenmcnaughton]

Code looks good - if someone does an r-run & confirms the html this is mergeable

[eileenmcnaughton]

I tested this locally & edited my findings in the PR template above. Summary = yes, this fixes a broken html tag.

Merging

[mlutfy]

thanks :)