Fix fatal when saving import mapping with a relationship but 'Primary' location type

[eileenmcnaughton]

Overview

Fixes a fatal error when saving an import mapping with field mapped to (for example) employer's phone with the location type set to primary

Mapping looks like this (bottom field is the issue)

Before

---

After

Saves

Technical Details

This occurs because the correct value to save for location_type_id of Primary is '' but the current code winds up casting to 0
which won't save as it there is a foreign key involved. Handling was previously added but only to the
(duplicate) code that deals with non-relationship fields

https://github.com/eileenmcnaughton/civicrm-core/blob/cd41fa5b5599b329bd6f54acf0a79dda85477804/CRM/Contact/Import/Form/MapField.php#L724

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[yashodha]

@eileenmcnaughton Are all the fields necessary to replicate? If not, can you highlight the one causing DB error.

[eileenmcnaughton]

@yashodha no - I mentioned above the bottom field is causing the issue - that is the only one necessary to replicate

[eileenmcnaughton]

@jitendrapurohit are you able to review this?

[jitendrapurohit]

Replicated and confirm that the issue is fixed by the changes done here. Also tested the outcome of the location type after import.

[eileenmcnaughton]

thanks @jitendrapurohit -merging