[Ref] [Import] Use processor to determine website type, location type, test

[eileenmcnaughton]

Overview

Minor cleanup on import

Before

Less readable

After

More readable

Technical Details

Part of a bigger cleanup - I'm slowly extending test cover & making the covered changes.

The way it DID work was an array like
[[0 => 1], [1 => ''],[2 =>'']
was passed around as $mappingWebsiteType. These were basically the values from the column website_type_id from the table civicrm_mapping_field indexed by column number & they were passed around for eventual lookup. We now load the mapping_fields into the ImportProcessor class and use it's functions to look up the values (which are NOT stored in separate column-indexed arrays but in a single array that reflects the underlying data structure from civicrm_mapping_field)

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[eileenmcnaughton]

test this please

[eileenmcnaughton]

@seamuslee001 this is passing - just same as similar ones - add a test & make a change to the newly tested line to simplify

[seamuslee001]

Change looks fine and consistent with other work. this has sufficient tests covering this area merging