Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export header for 'Contact ID' #15118

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Fixes

  1. the contact id field is exported with the heading 'contact_id' - should be 'Contact ID'
  2. code quality issue - we should have metadata defined for all fields but it is missing for
    a few (now one less)

Before

Heading 'contact_id' in export

After

Heading is 'Contact ID'

Technical Details

This is an integer field so it's fine for it to pick up the default length for integers (16 char) instead of the default length for 'I don't know' fields

Comments

Fixes
1) the contact id field is exported with the heading 'contact_id' - should be 'Contact ID'
2) code quality issue - we should have metadata defined for all fields but it is missing for
a few (now one less)
@civibot
Copy link

civibot bot commented Aug 23, 2019

(Standard links)

@civibot civibot bot added the master label Aug 23, 2019
@seamuslee001
Copy link
Contributor

Change makes sense there is good amount of test coverage here merging

@seamuslee001 seamuslee001 merged commit b26a4ee into civicrm:master Sep 5, 2019
@seamuslee001 seamuslee001 deleted the export branch September 5, 2019 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants