Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default domain to membershiptype API #15120

Merged

Conversation

mattwire
Copy link
Contributor

Overview

As identified in #14888

Before

No default domain for MembershipType API

After

Default domain for MembershipType API

Technical Details

Comments

@civibot
Copy link

civibot bot commented Aug 23, 2019

(Standard links)

@civibot civibot bot added the master label Aug 23, 2019
@eileenmcnaughton
Copy link
Contributor

@seamuslee001 @nganivet this is 'correct' but it's quite late in the piece to add it to apiv3 - do you think anything will break?

@seamuslee001
Copy link
Contributor

@eileenmcnaughton i think it sounds right, the only thing i can think of maybe in regards to AUG and the membership_type_id field on an advanced search

@eileenmcnaughton
Copy link
Contributor

I should note that it is only a default - I think you can override to empty if you want

@seamuslee001
Copy link
Contributor

Yeh and i have sought to do that via the multisite extension which feels more correct to me. I think its only on search forms where we want to be able to select multiple memberships. https://github.com/eileenmcnaughton/org.civicrm.multisite/pull/22/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants