Initial refactor of BaseIPN #15129
Merged
Initial refactor of BaseIPN #15129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Jenkins re test this please |
|
I read through this & there seems to be no functional change in it - we should get tests on it though |
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a preliminary cleanup with some of the tweaks from #14397 A lot of the code in this class is duplicated and needs cleaning up / extracting. The helps towards https://lab.civicrm.org/dev/core/issues/927
Before
Similar functions more difficult to compare / consolidate
After
Similar functions (cancelled/failed) easier to compare / consolidate
Technical Details
Comments