Extract function to create email activity when sending an email to contact

[mattwire]

Overview

Extract function that creates an email activity.

Background: I've had a number of requests to save the contents of an email after tokens have been parsed but the way it currently works is it saves a single activity pre-parsing and then creates activity contacts to link it to multiple contacts. This is a more efficient use of the database but a lot less friendly to the end-user admin who can't see what was actually sent to the contact. Note that this PR makes no changes - it just extracts the function that creates the activity so we can consider further refactoring.

Before

Create email activity embedded in main sendMessage function.

After

Create email activity extracted to it's own function.

Technical Details

There should be no functional change with this PR, just simplified/improved code.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I worked through this extraction & was able to reach the same result - merging