Add minimal test for testExportFinancialBatch #15136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
This adds the minimal test suggested as needed for civicrm#14621 In the process I needed to add some api defaults
eileenmcnaughton
force-pushed
the
batch_test
branch
from
1d76efa to
58f5a26
Compare
|
Only affects tests and looks fine to me merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds the minimal test suggested as needed for #14621
In the process I needed to add some api defaults
Before
No test, no defaults
After
Test, defaults - note defaults only apply on create (not update) - ideally modified_id & modified_date WOULD do 'something' when updated by the api but not in scope
Technical Details
Once merged #14621 can be retested & merged
Comments
@pradpnayak I wrote it for you...