dev/event#14 Fix excessive cache clearing on creating an event

[jaapjansma]

Overview

When creating or updating an event CiviCRM clears all caches.

Before

There seems to have been an issue with Memcache, CiviCRM, Drupal and Events. That when you create an event and press continue you will got a permission denied. See https://issues.civicrm.org/jira/browse/CRM-6734
The fix for that issue was simply clearing all caches.

After

Removed the line for clearing the caches upon creating and updating events.
I have tested the fix with memcache enabled to see whether the permission denied problem reappeared but it did not.

Comments

This fix also improves performance

See related lab.civicrm.org issue: https://lab.civicrm.org/dev/event/issues/14

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

TBH I thought we might get test fails here - since if the list of events is cached 'somewhere' but in the absence of that I'm OK to merge. Underclearing of caches generally hits unit tests first.

[jaapjansma]

Thanks for merging. I also thought that the test would fail with removing a clear cache.