Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distmaker - Finish migrating bower.json => composer.json #15148

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

totten
Copy link
Member

@totten totten commented Aug 28, 2019

Overview

This is a follow-up to #15044 - since we don't have/need bower.json, it doesn't make sense for distmaker to call bower install.

Before

  • distmaker tries to call bower install and publish bower.json

After

  • distmaker omits bower install and bower.json

This is a follow-up to civicrm#15044 - since we don't have/need `bower.json`, it
doesn't make sense for `distmaker` to call `bower install`.
@civibot
Copy link

civibot bot commented Aug 28, 2019

(Standard links)

@civibot civibot bot added the master label Aug 28, 2019
@eileenmcnaughton
Copy link
Contributor

I think the tarballs get pretty tested during release & rc process so happy to merge this & allow the work to progress

@eileenmcnaughton eileenmcnaughton merged commit cf5dff5 into civicrm:master Aug 28, 2019
@totten totten deleted the master-debower branch August 28, 2019 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants