Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Move clone template functionality from api to bao #15163

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

colemanw
Copy link
Member

Overview

Moves code block from one place to another, for better reusability in api4.

Before

Code in api.

After

Code in bao.

@civibot
Copy link

civibot bot commented Aug 29, 2019

(Standard links)

@mlutfy
Copy link
Member

mlutfy commented Aug 29, 2019

Test fail seems unrelated?

CRM_Member_BAO_MembershipTest::testRenewMembership
Verify correct end date is calculated after membership renewal
Failed asserting that two strings are equal.

@mlutfy
Copy link
Member

mlutfy commented Aug 29, 2019

jenkins, test this please

@colemanw
Copy link
Member Author

@mlutfy that looks to be a recent regression in core, I'm seeing it on a number of PRs. So other than that, this PR is passing tests.

@colemanw
Copy link
Member Author

retest this please

@colemanw
Copy link
Member Author

@mlutfy was that a "merge on pass" endorsement?

@mlutfy
Copy link
Member

mlutfy commented Aug 30, 2019

I don't always feel like the most qualified for this kind of PR, but considering you are the one who initially added this code in the API, and it makes sense to have it in the BAO instead, merge on pass! :)

@colemanw
Copy link
Member Author

retest this please

@eileenmcnaughton
Copy link
Contributor

test this please

@seamuslee001 seamuslee001 merged commit 0a5f41f into civicrm:master Aug 30, 2019
@colemanw colemanw deleted the eventClone branch August 30, 2019 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants