Fix PayPalImpl Contribution Status PseudoConstant for non-English

[mlutfy]

i.e. use the name property, not label.

Overview

When using PayPal Express, contributions were left pending when CiviCRM is not in English (or more specifically, when the label of the Contribution Status = Completed was not "Completed", ex: "Terminé"). It worked fine in English, since the name and label are the same.

Comments

I understand this Payment Processor is on its way out, to be replaced by PayPal Checkout, but we haven't finished testing yet, and had a client running into this bug.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

These just keep popping up!

[mlutfy]

yep, I think next time we add more Option Values, we should really make sure not to use name=label. At the very least, use lowercase for the name. That way the bugs will surface in English too.

[eileenmcnaughton]

unrelated fail