Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Very minor code cleanup on import code with good test cover #15173

Merged
merged 1 commit into from
Aug 31, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Very minor code cleanup - removes a few lines of code from well-tested chunk of code

Before

More code

After

less code

Technical Details

The value is equal to the phone id if one exists or the processor id - this just
uses the processor function to grab it

Comments

The value  is equal to the phone id if one exists or the processor id - this just
uses the processor function to grab it
@civibot
Copy link

civibot bot commented Aug 31, 2019

(Standard links)

@civibot civibot bot added the master label Aug 31, 2019
@seamuslee001
Copy link
Contributor

Change looks fine and we have a good solid amount of tests here

@seamuslee001 seamuslee001 merged commit d3b7433 into civicrm:master Aug 31, 2019
@seamuslee001 seamuslee001 deleted the mini branch August 31, 2019 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants