dev/core#1230 Loosen permissions to Dedupe.getstatistics api #15187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This api should have the same level of permission as Dedupe.getduplicates - it gets data about cached duplicates. Note that getduplicates has 'access CiviCRM' & relys on ACLs to restrict which contacts can be accessed through it
|
(Standard links)
|
eileenmcnaughton
changed the title
|
@colemanw also this should be straight forward |
|
makes sense to me merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a recently added api & the permissions turn out to be too restrictive (as I test with a less permissioned user)
This api should have the same level of permission as Dedupe.getduplicates - it gets data about
cached duplicates. Note that getduplicates has 'access CiviCRM' & relys on ACLs to restrict
which contacts can be accessed through it
The results of the function are simply counts of the number of skipped and merged rows from a given search set
Before
Dedupe.getstatistics requires Administer CiviCRM
After
Dedupe.getstatistics requires Access CiviCRM
Technical Details
This does not affect core code as this is only called from tests in core
Comments
https://lab.civicrm.org/dev/core/issues/1230