Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Import][ref] Minor code improvement - move setDefaults to processor #15189

Merged
merged 1 commit into from
Sep 4, 2019
Merged

[Import][ref] Minor code improvement - move setDefaults to processor #15189

merged 1 commit into from
Sep 4, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Very small code cleanup

Before

More crazy

After

Less crazy

Technical Details

Tests are good here

Comments

@civibot
Copy link

civibot bot commented Sep 2, 2019

(Standard links)

@civibot civibot bot added the master label Sep 2, 2019
@colemanw
Copy link
Member

colemanw commented Sep 4, 2019

Makes sense.

@colemanw colemanw merged commit 1f84e94 into civicrm:master Sep 4, 2019
@colemanw colemanw deleted the import_tiny branch September 4, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master sig:code maintenance readability testability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw