Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1187 Fix bug where import will not do 2 phone types of the same location #15190

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Sep 2, 2019

Overview

Fixes a bug whereby one phone number is not imported if 2 of the same location type but different phone types are in an import

Before

Import as described in https://lab.civicrm.org/dev/core/issues/1187 does not result in 2 phones

After

2 phones created

Technical Details

The issue is the indexing is squishing them into one

Comments

@civibot
Copy link

civibot bot commented Sep 2, 2019

(Standard links)

@civibot civibot bot added the master label Sep 2, 2019
@eileenmcnaughton eileenmcnaughton changed the title dev/core#1187 Fix bug where import will not do 2 phone types of the s… dev/core#1187 Fix bug where import will not do 2 phone types of the same location Sep 2, 2019
@eileenmcnaughton
Copy link
Contributor Author

@jitendrapurohit are you able to review this?

@jitendrapurohit
Copy link
Contributor

Replicated this issue and confirmed that the PR changes fixes the import of multiple phone values with same loc type.

@eileenmcnaughton This can be merged.

@mattwire mattwire merged commit 2eb224b into civicrm:master Sep 5, 2019
@mattwire
Copy link
Contributor

mattwire commented Sep 5, 2019

Merging based on @jitendrapurohit review

@eileenmcnaughton eileenmcnaughton deleted the import_bug branch September 5, 2019 20:26
@eileenmcnaughton
Copy link
Contributor Author

Thanks @jitendrapurohit @mattwire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants