dev/core#1230 [Dedupe] Add new api option to getduplicates, permitting a new search to be forced. #15196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rced. Per the inbuilt screen, sometimes there is a need to clear the cached duplicates & reload - e.g because more have been created in the mean time.
|
(Standard links)
|
eileenmcnaughton
changed the title
eileenmcnaughton
changed the title
|
@eileenmcnaughton We should really have a test to lock in this parameter, but I'm aware that you're doing lot's of work in this area so I'll merge and assume coverage will come later. |
|
thanks @mattwire - you are right there isn't cover on this option but there is a lot on the code around it - will see what I can do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Extra parameter for Dedupe.getduplicates - is_force_new_search allows the api to force a refresh of cached results
Before
No way to force a refresh by api if the cache is invalidated
After
New api parameter
Technical Details
Per the inbuilt screen, sometimes there is a need to clear the cached duplicates & reload - e.g because more have been
created in the mean time.
Comments
https://lab.civicrm.org/dev/core/issues/1230