Ensure all report templates switch the filter field_name from join_da… #15198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te to be membership_join_date
|
(Standard links)
|
|
I created a report on 5.17 & then upgraded with this patch & the report loaded the renamed field value - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…te to be membership_join_date
Overview
As part of #15177 we switched some report filter keys to be membership_join_date rather than join_date to match the new metadata, this PR aims to update that in the stored form_values in civicrm_report_instance
Before
stored form values using old filter key
After
stored form values using new filter key
ping @eileenmcnaughton