Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search for case tags that are part of tag sets #15212

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Fix search for case tags that are part of tag sets #15212

merged 1 commit into from
Sep 4, 2019

Conversation

mmyriam
Copy link
Contributor

@mmyriam mmyriam commented Sep 4, 2019

Overview

The current code only allows for searching tags that are part of the tag tree. A search for a tag that is part of a tag set will produce a DB Error. This fix allows for searching one or the other.

Before

The search produces a DB Error.

image

image

After

The search is successful.

Comments

This fix does not offer a solution for searching both a case tag in the tag tree and a case tag in a tag set at the same time. But then again the Advanced Search on Contact Tags doesn't either.

@civicrm-builder
Copy link

Can one of the admins verify this patch?

@civibot
Copy link

civibot bot commented Sep 4, 2019

(Standard links)

@civibot civibot bot added the master label Sep 4, 2019
@mmyriam mmyriam marked this pull request as ready for review September 4, 2019 13:47
@mlutfy
Copy link
Member

mlutfy commented Sep 4, 2019

add to whitelist

@colemanw
Copy link
Member

colemanw commented Sep 4, 2019

Thanks so much for contributing this fix @mmyriam. Our testbot found some whitespace issues with your patch. As a rule we use spaces instead of tabs to indent, and we do not allow trailing whitespace at the end of lines. Let me know if you need any assistance with that.

Changes to be committed:
	modified:   CRM/Case/BAO/Query.php
@mmyriam
Copy link
Contributor Author

mmyriam commented Sep 4, 2019

Thanks @colemanw. I've made the corrections. I'll be more careful next time.

@seamuslee001
Copy link
Contributor

Test failures unrelated merging

@seamuslee001 seamuslee001 merged commit 1f5d2c3 into civicrm:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants