[Import] [REF] code cleanup & test on the code to 'guess the intended field from the column name'

[eileenmcnaughton]

Overview

Minor cleanup

Before

Less readable, untested

After

More readable, tested

Technical Details

This gets us away from using the form session to pass around metadata & makes the functio testable.

In this case the metadata i the 'header pattern' from the xml - it's a bit of regex intended to look at the incoming column header & see if it is a match for any of our fields. Neat idea. It would be cool to hone it a bit but this just standardises how it is loaded

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[seamuslee001]

@eileenmcnaughton needs a rebase now

[eileenmcnaughton]

@seamuslee001 thanks - done

[seamuslee001]

looks fine to me added MOP