[Ref] [Import] Final round in the cleanup Load Mapping form epic #15226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
headers3
branch
from
a87fcdc to
e5cabbb
Compare
eileenmcnaughton
commented
Sep 6, 2019
| } | ||
| } | ||
| else { | ||
| // this load section to help mapping if we ran out of saved columns when doing Load Mapping |
There was a problem hiding this comment.
This else is the same as the else in the main function
|
Great work Eileen! |
The final result is that the 134 lines here https://github.com/civicrm/civicrm-core/blob/5.16/CRM/Contact/Import/Form/MapField.php#L407-L543 are now just 2 lines & we don't need a separte function Although this does now free us to replace the 30 lines above with a call to the shared function
eileenmcnaughton
force-pushed
the
headers3
branch
from
e5cabbb to
27a00f6
Compare
|
unrelated fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This removes all the now-obsolete code from the mapping cleanup
-94 + 30.... but that is just this PR
The final result is that the 134 lines here https://github.com/civicrm/civicrm-core/blob/5.16/CRM/Contact/Import/Form/MapField.php#L407-L543
are now just 2 lines
And these
https://github.com/civicrm/civicrm-core/blob/5.16/CRM/Contact/Import/Form/MapField.php#L202-L239
are 1
Before
Chaos
After
Calm
Technical Details
After all the cleanups & tests we can now remove some big chunks....
Comments
@seamuslee001 @colemanw so this is the final one in the series (the other 2 open PRs are sub-PRs of this for easier review)