Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/drupal#52 Partial fix for Deprecated q variable #15268

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

mlutfy
Copy link
Member

@mlutfy mlutfy commented Sep 10, 2019

Overview

In Drupal8, the 'q' variable is deprecated. This caused various warnings since the recent introduction of isFrontEndPage (68e3bc3).

Example: https://www.drupal.org/project/webform_civicrm/issues/3080284

Before

Annoying PHP notices.

After

No more notices.

Comments

This is only a partial fix to hush the notices. To fully support scenarios that have traditionally relied on q, we still need to create a patch for getUrlPath as described in https://lab.civicrm.org/dev/drupal/issues/52

This is a resubmission of #15265 to the RC branch.

@civibot
Copy link

civibot bot commented Sep 10, 2019

(Standard links)

@KarinG
Copy link
Contributor

KarinG commented Sep 10, 2019

Tested - ready to be merged

@seamuslee001
Copy link
Contributor

Thanks @KarinG

@totten
Copy link
Member

totten commented Sep 11, 2019

(Note: Copied+revised description from predecessor PR.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants