dev/drupal#52 Partial fix for Deprecated q variable #15268
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In Drupal8, the 'q' variable is deprecated. This caused various warnings since the recent introduction of
isFrontEndPage
(68e3bc3).Example: https://www.drupal.org/project/webform_civicrm/issues/3080284
Before
Annoying PHP notices.
After
No more notices.
Comments
This is only a partial fix to hush the notices. To fully support scenarios that have traditionally relied on
q
, we still need to create a patch forgetUrlPath
as described in https://lab.civicrm.org/dev/drupal/issues/52This is a resubmission of #15265 to the RC branch.