dev/core#1257 Make relationship description searchable #15358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
yashodha
reviewed
Sep 30, 2019
yashodha
reviewed
Sep 30, 2019
yashodha
reviewed
Sep 30, 2019
|
@colemanw The failing build is related, we should be passing array or nothing. |
colemanw
force-pushed
the
relDesc
branch
2 times, most recently
from
bdabbe1 to
f9b1540
Compare
|
@yashodha Can you test this again - are we good to merge? |
|
@mattwire tested this, working fine. I am merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Exposes the relationship description field to advanced search.
Before
Relationship description not searchable.
After
Relationship description searchable.
Comments
See https://lab.civicrm.org/dev/core/issues/1257