dev/core#1282 Takes care of customfields of type multiselect that were not being rendered

[VangelisP]

Overview

Customfields of type Multiselect attached to an Address do not render in profile page (appear empty). Related issue: https://lab.civicrm.org/dev/core/issues/1282

Before

MultiSelect customfield did not render values

After

MultiSelect customfield does render values

Technical Details

Examines (using switch) the html-type of the field to render, as already being done a few lines before: https://lab.civicrm.org/dev/core/blob/master/CRM/Core/BAO/UFGroup.php#L2373-2400
If of type:

• Multi-Select
• Multi-Select State/Province
• Multi-Select Country
• Checkbox
  default value assignment is following the logic of https://lab.civicrm.org/dev/core/blob/master/CRM/Core/BAO/UFGroup.php#L2373-2400

Comments

It seems that Checkbox works by itself. I could minimize the check only to the Multi-Select elements.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I feel like this is duplicating code & maybe we could extract & share it?

[VangelisP]

I believe this is much better.

I've isolated : https://lab.civicrm.org/dev/core/blob/master/CRM/Core/BAO/UFGroup.php#L2369-2395 into its own function and also took out completely that part as I rely now on the variable $field to get my information from (instead of the old manual way).

I believe we might need some reviewers because for example I don't play with cases and I don't know if this generates any issue over the case component.

[VangelisP]

I found out that if location type is Primary, select/multiselect would also not render. The latest commit fixes that as well

[eileenmcnaughton]

I did some digging into the code & this seems to all make sense / simplify the code.

I note that lines were removed that related to https://issues.civicrm.org/jira/browse/CRM-2969 but I tried to test the scenario described there and it worked from what I could see - screen shot below.

I'm still tinkering a bit more on tests but I did put one up #15638 - I think this is good to merge