Update tests to simulate labels that are not the same as names #15399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
pending
branch
3 times, most recently
from
2696faa to
0a68acf
Compare
eileenmcnaughton
changed the title
eileenmcnaughton
force-pushed
the
pending
branch
3 times, most recently
from
0a68acf to
cd83486
Compare
…re different in internationalised extensions Adjust tests for renamed labels
eileenmcnaughton
force-pushed
the
pending
branch
from
cd83486 to
91786f4
Compare
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Oct 13, 2019
Fixes a bug caused by civicrm@5b9d3ce And picked up in test with civicrm#15399
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Oct 13, 2019
Fixes a bug caused by civicrm@5b9d3ce And picked up in test with civicrm#15399
|
test this please |
|
Looks good makes sense to me and will help with us finding problems in the future Merging |
magnolia61
pushed a commit
to magnolia61/civicrm-core
that referenced
this pull request
Oct 16, 2019
Fixes a bug caused by civicrm@5b9d3ce And picked up in test with civicrm#15399
magnolia61
pushed a commit
to magnolia61/civicrm-core
that referenced
this pull request
Oct 16, 2019
Fixes a bug caused by civicrm@5b9d3ce And picked up in test with civicrm#15399
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We have an issue where it is too easy to check name rather than label in code & that is missed for English language but breaks stuff in translated CRM. This renames some labels (statuses of Pending & Refunded) within the test suite. The hope is to extend this to more labels later.
Before
No test cover for label !== name
After
Some coverr
Technical Details
I rename them back in tearDown as it seems good practice to try to not mess with the DB state - even though I keep resetting them
Comments