[NFC] minor simplification #15425
Merged
[NFC] minor simplification #15425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
ping @MikeyMJCO Changes look fine to me MOP |
|
|
on advice from @eileenmcnaughton closing |
This just changes how return vars are handled to make it clearer that ONLY contact::Create cares about location_block::create return values
eileenmcnaughton
force-pushed
the
loc_clean
branch
from
7d5258c to
9a35064
Compare
|
After seeing the comments it turns out this PR needed to be brought back to life. On digging it turns out the test fails were because the test actually only 'works' due to it by-passing everything it needs to test. I removed it instead. The squirrels party |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This just changes how return vars are handled to make it clearer that ONLY contact::Create
cares about location_block::create return values
Before
Squirrels up past their bedtime
After
Squirrels in bed & in la-la land
Technical Details
Comments