dev/financial#72 Modify getTemplateContribution() to use is_template field #15456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
- non-test recurs should only pick up non-test templates - test recurs should only pick up test templates Add test
aydun
force-pushed
the
change_getTemplateContrib
branch
from
b91a542 to
f306dbe
Compare
aydun
changed the title
|
This code looks good - logic as discussed / agreed in Barcelona sprint. We need to do some documenting ! Test looks good & existing test cover on this is really solid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Further part of dev/financial#72 - modify getTemplateContribution to prefer Contribution's with is_template
Before
getTemplateContribution() ignores is_template field
After
getTemplateContribution() prefers is_template field, falls back to old method.