Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes an issue where the two arrays weren't always being merged correctly #15482

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Fixes an issue where the two arrays weren't always being merged correctly #15482

merged 1 commit into from
Oct 10, 2019

Conversation

seamuslee001
Copy link
Contributor

Overview

This fixes a recently introduced issue where the 2 arrays of hooks wasn't properly being merged

Before

List of hooks not properly merged

After

array of hooks merged correctly

I have tested this locally and confirmed it to be working

@civibot
Copy link

civibot bot commented Oct 10, 2019

(Standard links)

@civibot civibot bot added the master label Oct 10, 2019
@mattwire
Copy link
Contributor

I've stepped through this and agree it fixes the issue

@seamuslee001 seamuslee001 merged commit 61dbc8d into civicrm:master Oct 10, 2019
@seamuslee001 seamuslee001 deleted the fix_merge_array branch October 10, 2019 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seamuslee001 @mattwire