Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test calling CRM_Financial_BAO_PaymentProcessor::getPaymentProcessors #15499

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 14, 2019

Overview

Add test to ensure calling with Test capability only returns testMode processors

Test was written as part of review for #15330 but in fact it doesn't pass before or after that is applied :-(

Before

No tests

After

Tests

Technical Details

I believe the function should be updated so the tests pass

Comments

Add test to ensure calling with Test capability only returns testMode processors
@civibot
Copy link

civibot bot commented Oct 14, 2019

(Standard links)

@seamuslee001
Copy link
Contributor

Test failures look related here but i guess that was kind of the point

@mattwire
Copy link
Contributor

@eileenmcnaughton Want to break out the test in tests/phpunit/CRM/Financial/BAO/PaymentProcessorTest.php to a separate PR. Then we can get the other two bits in this PR merged and continue work on the function/test

@eileenmcnaughton
Copy link
Contributor Author

@mattwire OK - I added a commit that marks the test incomplete for now

@mattwire mattwire merged commit cf3a4ee into civicrm:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants