dev/financial#73 Update Order.create so that total_amount is not required. #15501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
order
branch
from
de86462 to
328d8e3
Compare
…ired. As test shows it is otherwise created from the line items
eileenmcnaughton
force-pushed
the
order
branch
from
328d8e3 to
9c5edcd
Compare
|
Thanks @eileenmcnaughton |
|
I've updated the OrderAPI documentations PR (which is still a work in progress but referenced this bug) |
JoeMurray
reviewed
Oct 15, 2019
| */ | ||
| function civicrm_api3_order_create($params) { | ||
|
|
||
| civicrm_api3_verify_one_mandatory($params, NULL, ['line_items', 'total_amount']); |
There was a problem hiding this comment.
No, the 'total_amount' should not be required but be optional. If it is present, check that the line items total to it. If it is absent, set the total_amount to the sum of the line item amounts.
There was a problem hiding this comment.
Right so EITHER line_items OR total_amount are mandatory with this line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Per https://lab.civicrm.org/dev/financial/issues/73 total_amount should not be a required field for Order.create
Before
total_amount required
After
total_amount OR line_items required
Technical Details
As test shows it is otherwise created from the line items
Comments
@mecachisenros @artfulrobot @JoeMurray