[REF] remove obsolete code. #15515
Merged
[REF] remove obsolete code. #15515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On trying to look into a bug around this code I realised that there is quite a bit of code that does nothing. These lines exist to build the variable - which is never used. Hence they can go. I also spotted scriptArray is never used either - this stuff came from svn before everyone was using IDEs that highlighted unused lines
|
(Standard links)
|
|
Wow. Long function. Glad to see it get a little bit shorter. |
| 'post', | ||
| ] as $keys) { | ||
| if (isset($this->_values['additional_custom_' . $keys . '_id'])) { | ||
| $this->buildCustom($this->_values['additional_custom_' . $keys . '_id'], 'additionalCustom' . ucfirst($keys)); |
There was a problem hiding this comment.
seems like this is required to load profiles for additional participants? Currently, no fields are displayed on the page.
There was a problem hiding this comment.
Have requested a PR here #15698. Seems like only this line is required ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
On trying to look into a bug around this code I realised that there is quite a bit of code that does nothing.
These lines exist to build the variable
$required- which is never used. Hence they can go.I also spotted scriptArray is never used either - this stuff came from svn before everyone was using IDEs that
highlighted unused lines
Before
More code - no more functionality
After
Less code, same functionality
Technical Details
Comments
Anything else you would like the reviewer to note