Fix error when adding activities from Search Builder #15522
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When you use the "Add Activity" task from Search Builder, you get an error on submitting the activity. Exact replication steps are on the issue: https://lab.civicrm.org/dev/core/issues/1323
Before
Yellow Screen of Death.
After
No error.
Technical Details
When you submit the activity, CiviCRM tries passing you back to the search screen you just came from. However, it doesn't handle Search Builder.
Comments
I'm tagging this as
easy-review
because of the simplicity of the steps to replicate, the limited scope of the class being altered, and the obvious correctness of the fix :)