Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for participant receipts, super minor consistency fix. #15525

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

This is mostly adding testing for participant receipts. The one change to core code is to move the assignment
of contactID to the template from a specific path into the shared code. This parameter is not required by
the templates but it is somewhat common for sites to want to have it assigned to templates for
customisation which is presumably why it's there. Since it is there in one path we should either remove or
have it in all & for a field like contactID all makes sense. Tests lock in that var

Before

Less tests

After

More tests

Technical Details

Comments

I'm mostly trying to build up the test suite here so we can have another go at moving events to create pending + create payment.

I think we should remove $contributeMode from the tpl next

@mattwire @kcristiano

@civibot
Copy link

civibot bot commented Oct 16, 2019

(Standard links)

This is mostly adding testing for participant receipts. The one change to core code is to move the assignment
of contactID to the template from a specific path into the shared code. This parameter is not required by
the templates but it is somewhat common for sites to want to have it assigned to templates for
customisation which is presumably why it's there. Since it is there in one path we should either remove or
have it in all & for a field like contactID all makes sense. Tests lock in that var
@mattwire mattwire merged commit bca89ce into civicrm:master Oct 17, 2019
@eileenmcnaughton eileenmcnaughton deleted the evetn_template branch October 18, 2019 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants