Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate two string in AdditionalPayment form #15577

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Translate two string in AdditionalPayment form #15577

merged 1 commit into from
Oct 22, 2019

Conversation

mattwire
Copy link
Contributor

Overview

Wrap two strings in ts so they can be translated on the additionalpayment form.

Before

Not translateable

After

Translateable

Technical Details

Comments

@mlutfy Are you able to review?

@civibot
Copy link

civibot bot commented Oct 22, 2019

(Standard links)

@civibot civibot bot added the master label Oct 22, 2019
@mlutfy
Copy link
Member

mlutfy commented Oct 22, 2019

Seems OK, although I didn't test.

colemanw
colemanw requested changes Oct 22, 2019
View reviewed changes
Copy link
Member

@colemanw colemanw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 274 needs to be fixed as well.

@mattwire mattwire force-pushed the translate_additionalpayment branch from 85f5ffa to 78e1e6b Compare October 22, 2019 18:54
@mattwire
Copy link
Contributor Author

@colemanw Well spotted :-) fixed

@mattwire mattwire requested a review from colemanw October 22, 2019 18:55
@seamuslee001 seamuslee001 merged commit 8488b33 into civicrm:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colemanw colemanw colemanw approved these changes

Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattwire @mlutfy @colemanw @seamuslee001