Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noisy deprecation warning to Contribution.transact #15591

Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Add a deprecation notice when people use the broken Contribution.transact api.

The Order api has been the recommended api for several years & was adopted over a year ago by by the wordpress integration - the bottom of this page contains instructions for getting off it https://docs.civicrm.org/dev/en/latest/financial/OrderAPI/

Currently it IS broken and while it's possible to install an extension to fix it we should strongly discourage people from using it.

Before

No warning that it is unsupported & broken

After

Warning

Technical Details

Comments

@colemanw since you merged the PR allowing people to override it please merge this

Note that the Order api has been an adequate replacement for over a year - per efforts by wordpress integration
@civibot civibot bot added the master label Oct 23, 2019
@civibot
Copy link

civibot bot commented Oct 23, 2019

(Standard links)

@eileenmcnaughton
Copy link
Contributor Author

See #15504

@seamuslee001 seamuslee001 merged commit 7e66210 into civicrm:master Oct 23, 2019
@seamuslee001 seamuslee001 deleted the noisy_deprecate_transact branch October 23, 2019 21:29
@KarinG
Copy link
Contributor

KarinG commented Mar 2, 2020

@mattwire
Copy link
Contributor

mattwire commented Mar 2, 2020

@KarinG
Copy link
Contributor

KarinG commented Mar 2, 2020

So you'll be updating the deprecation notice then to the correct URL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants