Add noisy deprecation warning to Contribution.transact #15591
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add a deprecation notice when people use the broken Contribution.transact api.
The Order api has been the recommended api for several years & was adopted over a year ago by by the wordpress integration - the bottom of this page contains instructions for getting off it https://docs.civicrm.org/dev/en/latest/financial/OrderAPI/
Currently it IS broken and while it's possible to install an extension to fix it we should strongly discourage people from using it.
Before
No warning that it is unsupported & broken
After
Warning
Technical Details
Comments
@colemanw since you merged the PR allowing people to override it please merge this