Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update api3 explorer url path for consistency #15597

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

colemanw
Copy link
Member

Overview

For consistency with the api4 explorer let's include the version in the url.

Before

Api3 explorer at civicrm/api.

After

Api3 explorer at civicrm/api3. Redirects from civicrm/api.

@civibot
Copy link

civibot bot commented Oct 24, 2019

(Standard links)

@civibot civibot bot added the master label Oct 24, 2019
colemanw added a commit to civicrm/civicrm-dev-docs that referenced this pull request Oct 24, 2019
@homotechsual
Copy link
Contributor

I'm not seeing where the redirect is defined from reading the code on this one?

@@ -85,6 +85,12 @@
</item>
<item>
<path>civicrm/api</path>
<page_callback>CRM_Core_Page_Redirect</page_callback>
<page_arguments>url=civicrm/api3</page_arguments>
<access_arguments>access CiviCRM</access_arguments>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeyMJCO this adds the redirect.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :-D missed that!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do an r-run on this shortly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This runs fine locally - both URLs work.

@homotechsual
Copy link
Contributor

@seamuslee001 seamuslee001 merged commit f96eb23 into civicrm:master Oct 24, 2019
@seamuslee001
Copy link
Contributor

thanks @colemanw @MikeyMJCO

@colemanw colemanw deleted the apiPath branch November 4, 2019 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants