Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change test to use preferred methods, fix revealed money bug #15622

Merged
merged 1 commit into from
Oct 27, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Switches to preferred function calls, fixes revealed money cleaning bug

Before

Calling Payment.create with total_amount => '2,000.00' fails

After

Calling Payment.create with total_amount => '2,000.00' works in the same way as Contribution.create

Technical Details

In switching this test over I found that Payment.create does not handle cleaning money - which it should to bring it
into line with Contribution.create api

Comments

@civibot
Copy link

civibot bot commented Oct 27, 2019

(Standard links)

@civibot civibot bot added the master label Oct 27, 2019
In switching this test over I found that Payment.create does not handle cleaning money - which it should to bring it
into line with Contribution.create api
@seamuslee001
Copy link
Contributor

Change makes sense to me tests have passed i see no issues with this merging

@seamuslee001 seamuslee001 merged commit 75d91d0 into civicrm:master Oct 27, 2019
@seamuslee001 seamuslee001 deleted the deprecate_bad branch October 27, 2019 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants