Change parent class on mailing_form #15629
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Just changes the parent class to be more like the other search forms. Also adds the call to getSearchFieldMetadata but at this stage it's not using it to add fields
Before
Extends CRM_Core_Form
After
Extends CRM_Core_Form_Search
Technical Details
From https://github.com/civicrm/civicrm-core/pull/15369/files
Comments
I did some tests & it seemed to change nothing = good