Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change parent class on mailing_form #15629

Merged
merged 2 commits into from
Oct 27, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 27, 2019

Overview

Just changes the parent class to be more like the other search forms. Also adds the call to getSearchFieldMetadata but at this stage it's not using it to add fields

Before

Extends CRM_Core_Form

After

Extends CRM_Core_Form_Search

Technical Details

From https://github.com/civicrm/civicrm-core/pull/15369/files

Comments

I did some tests & it seemed to change nothing = good

@civibot
Copy link

civibot bot commented Oct 27, 2019

(Standard links)

@civibot civibot bot added the master label Oct 27, 2019
@seamuslee001
Copy link
Contributor

(CiviCRM Review Template WORD-1.2)

@seamuslee001 seamuslee001 merged commit a39f849 into civicrm:master Oct 27, 2019
@seamuslee001 seamuslee001 deleted the mailing_form branch October 27, 2019 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants