Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Test class preliminary clean up #15685

Merged
merged 1 commit into from
Nov 1, 2019
Merged

[NFC] Test class preliminary clean up #15685

merged 1 commit into from
Nov 1, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[NFC] Test class preliminary clean up

Before

Messier

After

Tidier

Technical Details

Comments

@civibot
Copy link

civibot bot commented Nov 1, 2019

(Standard links)

@civibot civibot bot added the master label Nov 1, 2019
@eileenmcnaughton eileenmcnaughton force-pushed the refund_allocate branch 4 times, most recently from f9f5730 to a981822 Compare November 1, 2019 02:41
@eileenmcnaughton eileenmcnaughton mentioned this pull request Nov 1, 2019
Closed
@eileenmcnaughton
Copy link
Contributor Author

test this please

@mattwire
Copy link
Contributor

mattwire commented Nov 1, 2019

@eileenmcnaughton This doesn't look like an NFC change - as it's refactoring some core code.

@eileenmcnaughton
Copy link
Contributor Author

That second commit should not have been in there - I've removed it @mattwire

@eileenmcnaughton eileenmcnaughton merged commit d9959f1 into civicrm:master Nov 1, 2019
@eileenmcnaughton eileenmcnaughton deleted the refund_allocate branch November 1, 2019 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @mattwire