Cleanup date handling on Payment.create

[eileenmcnaughton]

Overview

Fix a bug identified by @kcristiano whereby adding a payment with the
additional payment form changes the contribution receive_date.

Also, add a default to Payment.create of 'now' for the
trxn_date and require it to be set. Use that value later on.

Some string fixes

Before

Adding a payment on AdditionalPaymentForm changes Contribution.receive_date

After

Contribution.receive_date not altered

Technical Details

@kcristiano @magnolia61

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Unrelated fail

[eileenmcnaughton]

test this please

[eileenmcnaughton]

test this please

[eileenmcnaughton]

test this please

[magnolia61]

I tested this and can confirm it works.

[mattwire]

Merging based on review + @magnolia61 test

[kcristiano]

@eileenmcnaughton I am still having an issue on Received Date in the bookkeeping report.

The dates on the contribution screen look correct:

This looks more like a reporting issue.

[seamuslee001]

@kcristiano what is the date received on the contribution screen? like when you click the view link on the contribution its self?

[kcristiano]

@seamuslee001 That is the second screen shot and those dates are correct.

[kcristiano]

The Contrib report only picks up one date from civicrm_contribution

[seamuslee001]

@kcristiano yeh the 2nd screenshot in your previous comment only had the payments showing

[eileenmcnaughton]

@kcristiano I think that is not exactly a bug - ie. the trxn_date is shown on your report & it's correct. We should possibly not offer the receive date as a field or rename it or otherwise make it clear it's not the trxn_date

[kcristiano]

The trx_date is when the transaction is created. The received date is used by many of our client using cash basis accounting.

I am going to look again and re-evaluate.

This is an improvement, but we need to not change prior behavior - and I need to test for that. Specifically a line item's receive date should not change if edited.

[eileenmcnaughton]

@kcristiano yep - I'm keen to see a thorough set of testing done on 5.20